fix(deps): move zod from dev to prod catalog#230
Merged
Conversation
zod was incorrectly placed in the dev catalog while being used as a production dependency. This change: - Moves zod definition from catalogs.dev to catalogs.prod in pnpm-workspace.yaml - Updates package.json to reference catalog:prod instead of catalog:dev This ensures the catalog classification accurately reflects the dependency's actual usage in production code.
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the catalog classification of the zod dependency by moving it from the development catalog to the production catalog, where it belongs based on its usage in the source code.
Key changes:
- Moves
zod: ^4.1.13fromcatalogs.devtocatalogs.prodin pnpm-workspace.yaml - Updates the package.json dependency reference from
catalog:devtocatalog:prod - Updates pnpm-lock.yaml to reflect the catalog change
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Moves zod from dev catalog to prod catalog |
| pnpm-lock.yaml | Updates lockfile to reflect the catalog change and new specifier reference |
| package.json | Changes zod dependency reference from catalog:dev to catalog:prod |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zodfromcatalogs.devtocatalogs.prodin pnpm-workspace.yamlcatalog:prodinstead ofcatalog:devTest plan
pnpm installruns successfullySummary by cubic
Moved zod from the dev catalog to the prod catalog to match its runtime use. This ensures zod is installed in production builds.
Written for commit 839f58b. Summary will update automatically on new commits.